Fix initialization issue with single smooth tendency#18
Merged
SBlokhuizen merged 3 commits intodevelopfrom May 26, 2025
Merged
Conversation
maarten-ic
reviewed
Feb 18, 2025
| self.from_ = 0.0 | ||
| self.to = 0.0 | ||
| super().__init__(**kwargs) | ||
| self._update_values() |
Collaborator
There was a problem hiding this comment.
_update_values also has the on_init=True flag in the @depends decorator. Do you know why that is not sufficient?
Collaborator
Author
There was a problem hiding this comment.
Yes, the on_init=True will cause the method to be called when the __init__ of the param.Parametrized base class is called, namely here. Since we now set the parameters after the intialization, the method is not called again.
Alternatively, a more declarative way to handle this would be:
@depends(
"_trigger",
"from_",
"to",
"start",
"end",
"start_derivative",
"end_derivative",
watch=True,
on_init=True,
)
At the expense of more triggers. We then should also account for the intermediate triggers (for example, CubicSpline will throw an error if start > end, which could occur if start is updated before end).
maarten-ic
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the spline object of the smooth tendency was not properly updated after creation.
For example:
Before:

After:
